Activity

psf/black repo issues and pull requests
- Remove unnecessary parentheses from `except` clauses #2939 [jpy-git]
  Description Closes #2937. As described in the issue we want to remove redundant parentheses from except...
- change some numeric behavior #469 [JelleZijlstra]
  Closes #467.
- Overhaul diff-shades integration to fail on stable changes and preview changes for all projects #2951 [ichard26] skip news C: maintenance
  Description Now PRs will run two diff-shades jobs, "preview-changes" which formats all projects with preview=True,...
  - JelleZijlstra
- Remove underscores in numeric literals #2957 [jpy-git] R: rejected T: design
  Is your feature request related to a problem? Please describe. I've just learned that this a = 1_2_3_4_5.6_7_8_9 is...
  - JelleZijlstra: We previously did this (inserting underscores every third digit only), but undid it because it...
  - jpy-git: I agree it would be a hassle to try and handle the every third digit logic. My suggestion was...
  - JelleZijlstra: Well, I'd feel bad about making Black totally remove all usage of a language feature :) The...
  - jpy-git: haha that's a fair point, in that case I understand why we leave it the users to handle these! Thanks 😄
- Long with statements are not broken into several lines #664 [mhham] T: design F: parentheses S: accepted C: target version
  Long with statements are not not broken into several lines: Something like this should be OK, according to PEP8 with...
- Remove unnecessary parentheses from `with` statements #2926 [jpy-git]
  Description Closes #2921. Aims to remove redundant parentheses from with statements: I currently have one failing...
  - jpy-git: One thing that I've noticed this PR doesn't currently do is add optional brackets if there...
  - JelleZijlstra: We should add these parentheses, but probably in a separate PR. There is already a framework for...
  - jpy-git: Fab thanks, just wanted to check/make you aware whilst reviewing this PR. Will follow up with a...
  - ichard26: This has been discussed in #664 and #1948 FYI.
  - github-actions: diff-shades reports zero changes comparing this PR (639a2e4) to main (f239d22). What is this? |...
- Convert `index.rst` and `license.rst` to markdown #2852 [gunungpw] skip news
  Description resolve #2840 Rename and convert index.rst and license.rst to index.md and lisence.md. fix ref link...
  - ichard26: I took care of the cleanup. This is good to land now!
  - gunungpw: Thank you 😊 Hope you have a nice day
  - ichard26: Hmm, I need to figure out what to do with the reference section of the contributing docs, but...
  - JelleZijlstra
- Comments between fmt:on/off are reformatted #1245 [marcelm] T: bug F: comments F: fmtoff
  This code: # fmt: off #nospace # twospaces # fmt: on is changed to: # fmt: off # nospace # twospaces # fmt: on I...
  - aljabadi: Thanks for creating the best opinionated formatter I've used. I'm having this issue with...
- Add a --single-quotes option to prefer single quotes #633 [davvid]
  Now there are no excuses not to use black. Fixes #594
  - rspadim: Could the brunette --single-quotes be imported to black?
- Pin click between 8.0.0 and 8.0.4 as 8.1.0 drops Python 3.6 #2965 [ichard26]
  Description Checklist - did you ... Add a CHANGELOG entry if necessary? Add / update tests if necessary? Add...
  - ichard26: Could someone please update the changelog for me? I don't have access to my main machine right...
  - JelleZijlstra
  - woodruffw: Does it make sense to remove the patch entirely (or add ImportError to it), per #2964 (comment)?...
  - JelleZijlstra: @woodruffw probably, looking into that now
  - woodruffw: (My unsolicited 0.02c: this is probably the ideal patch, since it preserves the fix for Python...
  - ichard26: Closing as this was made under a false assessment of the situation.
- Remove usage of _unicodefun module from dependency: 'click' #2967 [bcrant]
  Description The _unicodefun module has been removed from the click library. In addition, it is also not actively...
  - JelleZijlstra: Thanks, closing in favor of #2966.
  - ichard26: We still need this so 3.6 still works even if LANG is misconfigured for unicode.
  - bcrant: Right on! Glad there was an easy fix. Thanks for being on top of it! Cheers
- Prepare release 22.3.0 #2968 [JelleZijlstra] skip news
  - JelleZijlstra: This had ended up in "Parser" somehow
    - ichard26: I was trying to figure out why this line was changed, makes sense :)
  - ichard26: LGTM.
- Bug using a previous click version #2969 [nidhaloff] T: bug R: duplicate C: installation / packaging
  Describe the bug It looks like black is depending on click>=1.8.0, However, click changed the API in the new version...
  - JelleZijlstra: Fixed in Black 22.3.0, published a full two minutes ago. See #2964.
  - ichard26: Already resolved, see #2964. Thanks anyway!
- black fails due to _unicodefun #2963 [NAThompson] T: bug R: duplicate C: installation / packaging
  Describe the bug On Centos 7: WARNING: You are using pip version 21.2.3; however, version 22.0.4 is available. $...
  - laundmo: I found a solution: this is a issue with the newest click. if you install click==8.0.4 it should work
  - Sillocan: Yep. Click 8.1.0 was released with a breaking change.
  - JelleZijlstra: Going to close in favor of #2964 which is now pinned.
- Correctly handle fmt skip comments without internal spaces #2970 [siuryan]
  Description Hi, first time contributor here! This PR fixes #2917 . The issue was that fmt skip comments were being...
  - siuryan: Is setting leaf.prefix to empty string here okay? It appears leaf.prefix can only ever contain...
  - github-actions: diff-shades reports zero changes comparing this PR (9e3d823) to main (ae2c075). What is this? |...
- Add improved docstring processing #2885 [TomFryers]
  Description One of the things discussed in issue #144 was quote placement. Reading through the discussion, there...
  - github-actions: diff-shades results comparing this PR (e073b63) to main (ae2c075). The full diff is available in...
- Address breakage of our test suite *before* aiohttp 4.0.0 goes out of alpha #2971 [ichard26] help wanted C: maintenance
  So thanks to the various dependency related fires we've had lately, I've created ichard26/black-deps-ci which runs...
  - ichard26: It's worth noting even though a substantial amount of our dependencies have removed Python 3.6...
- ImportError: cannot import name 'echo' from 'click' (unknown location) #2634 [salmanhiro] T: bug C: dependencies C: crash S: awaiting response
  I'm using Python 3.8.9 with conda environment and resulted in this problem Traceback (most recent call last): File...
  - arturomf94: Getting something similar in a GitHub Actions workflow running 3.7.12: Traceback (most recent...
  - JelleZijlstra: @arturomf94 you're using an old version of Black.
  - pmolodo: "old" meaning more than 5 hours ago: https://github.com/psf/black/releases/tag/22.3.0 (For the...
  - JelleZijlstra: "old" meaning more than 5 hours ago: No, much older than that.
  - arturomf94: Tbf, I think I am using and older one! I believe it's black==20.8b1.
  - pmolodo: Hmm - ok, how old, then? I was just writing some workaround code which is checking the version...
  - JelleZijlstra: Any version before 22.3.0 will fail. I was just pointing out that @arturomf94 was running a much...
  - dahluwalia-ag: I'm also having this error using pre-commit. pre-commit is using verison "21.12b0" so I will try...
  - dahluwalia-ag: Changing to version 22.3.0 has solved the problem... thanks!
  - arturomf94: Pinned on 22.3.0 - works now 👍. Thanks @JelleZijlstra. I think that change probably broke a lot...
  - flipbit03: Just ran into the same issue on black via pre-commit. Moving to 22.3.0 fixed it. Thank goodness.
  - JKCai: thanks for the almost live chat and solution. Save me from troubleshooting my environment.
  - flipbit03: This was exactly my impression @JKCai, I just found this issue and we live debugged it together...
  - JuanEscorcia: thanks a lot! :D
  - JelleZijlstra: I don't know how everyone ended up on this unrelated issue but glad it helped :) For the record,...
- Fix _unicodefun patch code for Click 8.1.0 #2966 [JelleZijlstra]
  Fixes #2964
  - github-actions: diff-shades reports zero changes comparing this PR (2ebdcc3) to main (ac7402c). What is this? |...
  - JelleZijlstra: Merging now because I'm pretty sure this isn't going to break PyPy on MacOS only.
  - tjeck97: breaks black==19.10b0 ImportError: cannot import name '_unicodefun' from 'click'
  - JelleZijlstra: @tjeck97 black 19.10b0 is old. Please upgrade.
  - tjeck97: @tjeck97 black 19.10b0 is old. Please upgrade. well now i'm forced to 😅 though pinning...
  - mirayyuce: With Version: 22.1.0 I still get the same error
  - JelleZijlstra: This PR was released in version 22.3.0.
  - cooperlees: Why do we pin < 8.1.0 if this fixes the bug? What am I missing - Is this for diff-shades?
  - vhosakot: This PR was released in version 22.3.0. can confirm this issue is fixed in black 22.3.0.
- Incompatible with click 8.1.0 (ImportError: cannot import name '_unicodefun' from 'click') #2964 [stumpylog] T: bug C: installation / packaging
  Please use Black 22.3.0 which was just released to fix this issue or pin Click to 8.0.0, 8.0.1, 8.0.2, 8.0.3, or...
  - liranbg: @stumpylog try with locking click to click==8.0.1
  - bradleyhurley: I just came here to open a very similar issue. The issue is caused by the release of click...
  - woodruffw: +1: We have a failure in pip-audit here: trailofbits/pip-audit#249 (click is strictly a...
  - scasagrande: For those that are running black via pre-commit, you can pin click to 8.0.4 via the following: -...
  - JelleZijlstra: We should probably pin to <8.1.0 for now. I can help get a release out later today to do that.
  - davidism: Why was black importing an internal module? I was not expecting this to be the change that...
  - woodruffw: Why was black importing an internal module? I was not expecting this to be the change that...
  - mjpieters: The import doesn't raise ModuleNotFoundError, only a plain ImportError, because from click...
  - davidism: Well good news at least, that whole patch isn't needed anymore, since Click itself is now at the...
  - ProGamerGov: This causing black to fail when run on Google Colab right now as well.
  - JelleZijlstra: We do still need the patch. On Python 3.6 + Click 8.0.4 + LANG=C, Click aborts with...
  - ichard26: Oh wow, Click 8.1.0 drops support for Python 3.6. We will have to either drop 3.6 soon or pin...
  - ichard26: Oh wow, Click 8.1.0 drops support for Python 3.6. We will have to either drop 3.6 soon or pin...
  - JelleZijlstra: We just released Black 22.3.0 with the fix. Sorry for the disruption everyone! (There are no...
  - ichard26: Mypyc compiled wheels are now also available 🚀
  - UnderratedNorf: How can I fix my failing gitlab pipeline that uses pre-commit ? I'm not sure how to pin Click...
  - ichard26: @UnderratedNorf either update black to 22.3.0 in the pre-commit-config.yaml file (remember...
  - Edwardx89: Is it me or does 22.3.0 still did not fix it? Using black==22.3.0 with click==8.1.0
  - JelleZijlstra: @Edwardx89 could you show more of the stack trace with line numbers? I suspect you're not...
  - scasagrande: @Edwardx89 it is working across the board for me, I don't think you're running the version you...
  - Edwardx89: @JelleZijlstra @scasagrande
  - JelleZijlstra: You're running an ancient version from back when the whole thing was in black.py.
  - scasagrande: @Edwardx89 you are running pip freeze on your pipeapp venv, but black is installed and running...
  - Edwardx89: @scasagrande Ahhh you are right!!! Sorry! It does work :)
  - vhosakot: can confirm this issue is fixed in black 22.3.0.
  - siaccarino: It is still not working: pip list black 22.3.0 click 8.1.0 ...
  - mjpieters: It is still not working: pip list black 22.3.0 click 8.1.0 ...
  - AqeelAT: Github action still fails. I tried: - name: Black Format Check uses:...
  - laymonage: And none of them worked. They all give the same ImportError. I think it could be a caching...
  - AqeelAT: And none of them worked. They all give the same ImportError. I think it could be a caching...
- Black should format docstring line length #2865 [danohn] T: design F: strings / docstrings F: linetoolong F: linebreak
  Describe the style change Black should format docstring line length. Examples in the current Black style def...
  - ubalklen: Not saying this should be solved by Black, but docformatter will only help so much. Their line...