Sample Dinghy report - Activity

• psf/black repo issues and pull requests

  • Black --preview mode produces invalid code in the first pass, causing second pass to fail #3117 [yilei] T: bug

    Describe the bug Black's --preview mode produces invalid code in the first pass, causing second pass to fail. To...

  • Black doesn't wrap functions with parameter comments #3113 [liam-mipac] T: bug F: comments F: linebreak

    Describe the bug If a line that exceeds the character limit has parameter comments, the function won't be moved to a...

  • Line break before operator added only with `--experimental-string-processing` #2491 [Zac-HD] T: bug F: strings / docstrings F: linebreak

    Running Black on the following code makes no changes: ( "whatever" == "a very long string broken across two...

  • Black should enforce zero empty leading lines in function body #902 [rogalski] T: design F: empty lines S: accepted

    Operating system: playground Python version: playground Black version: master Consider following code snippet: class...

  • Remove newline after code block open #3035 [saroad2]

    Description Fixes #902 Newlines are great. They help us organize our code and leave room for the coders and...

    • ichard26: I still haven't looked into the test infrastructure improvements, but everything else looks...

      • ichard26: This AUTHORS list is so out of date, gosh. Good for you adding yourself!

      • ichard26: Haha, I like it!

      • ichard26: Oh lovely, I've been worried lately our style documentation is out of date with the current...

    • felix-hilden: With three approvals, I think it's high time we get this in! Thanks for the contribution,...

  • Add improved docstring processing #2885 [TomFryers]

    Description One of the things discussed in issue #144 was quote placement. Reading through the discussion, there...

    • felix-hilden: Yo Tom, thanks for keeping this up to date! I think before this is merged, we'll have to decide...

    • github-actions: diff-shades results comparing this PR (f51ea0a) to main (4bb7bf2). The full diff is available in...

  • Update documentation dependencies #3118 [ichard26] T: documentation C: dependencies skip news C: maintenance

    Description It's easier to update all of them at once. Checklist - did you ... Add a CHANGELOG entry if...

    • JelleZijlstra

    • felix-hilden: The docs build passed, so it's a 👍 from me! 😄

  • use is_number_token insteaed of assertion #3069 [MarcoGorelli] skip news

    Description Checklist - did you ... Add a CHANGELOG entry if necessary? Add / update tests if necessary? Add...

    • felix-hilden: So is TypeGuard is enforced with mypyc? If not, we're missing an assert. (Just wanting to make...

      • MarcoGorelli: I'm not familiar with mypyc, so handling over to @ichard26 for this one

      • felix-hilden: As I understood the doc, TypeGuard is not equivalent to isinstance at runtime 🤔 at least without...

      • MarcoGorelli: I don't think it's needed, IIUC the assert was only there originally as a hint to mypy, it's not...

      • felix-hilden: Oh, I see. If this is the case then consider it resolved!

      • ichard26: Yeah I don't think it's even possible for this assertion to fail as the CST types representing...

    • felix-hilden

    • ichard26

  • Remove trailing spaces in f-string expressions #3119 [saroad2]

    Description Added a new feature in preview mode: Black now knows how to trim trailing whitespaces inside...

    • github-actions: diff-shades results comparing this PR (7ac878c) to main (162ecd1). The full diff is available in...

    • zsol: Hey, thanks for taking a stab at this. I have two concerns: This only solves the problem...

  • Test run black on self #3114 [saroad2] skip news

    Description Removed the hard coded SOURCE list from test_format.py. Now, black is run as part of the Lint CI and...

    • saroad2: Hey @cooperlees , Why do you want to run Black on itself as a unit test? In my opinion, this is...

    • github-actions: diff-shades reports zero changes comparing this PR (905a7c0) to main (162ecd1). What is this? |...

    • cooperlees: Why do you want to run Black on itself as a unit test? Because we already get the "system test"...

    • cooperlees: I also think we don't need a redundant second run of black on itself ...

    • saroad2: Hey @cooperlees . How about running black with the --diff flag or --verbose? This will allow you...

    • cooperlees: There are benefits to running each way. Minimal, but there are benefits, as mention above. Let...

    • saroad2: Hey @cooperlees , The reason I don't think that running pre-commit is enough is that pre-commit...

  • [Feature Request] Optimize imports #333 [devxpy] T: enhancement help wanted

    Can we please have a feature, similar to PyCharm's "optimize imports" feature, which basically sorts and removes...

    • mcarans: I am running blackd from PyCharm via the BlackConnect plugin. It would be great if black handled...

created at 2022-06-12 16:29 by dinghy 0.12.0.