Activity

psf/black repo issues and pull requests
- diff-shades: force --preview for PRs and pushes #2891 [ichard26] skip news C: maintenance
  Description This will let us gauge the impact of a change ahead of time. Checklist - did you ... Add a CHANGELOG...
- Bump mypy, flake8 and pre-commit-hooks in pre-commit #2922 [ichard26] skip news C: maintenance
  Description It's been a while since I last ran pre-commit autoupdate. Checklist - did you ... Add a CHANGELOG...
  - ichard26: Sadly I can't bump mypy for compilation as mypyc/mypyc#917 is still not fixed.
  - MarcoGorelli: Might want to also update the url of flake8 (which is now on github) so that gets auto updated too?
  - JelleZijlstra
  - ichard26: Good catch!
  - JelleZijlstra
- Black stops looking for config at first pyproject.toml file even if there's no black section in it #2863 [slafs] T: enhancement C: command line / config
  Disclaimer: I was hesitant whether I should report this as a bug or rather a "Feature request". Describe the bug In...
  - jaklan: I also find it pretty problematic in a monorepo setup: pre-commit hook doesn't work as you can...
  - jaklan: @Shivansh-007 I did a quick test with isort - if there's intermediate pyproject.toml, but...
  - Shivansh-007: Yeah, that PR is expected to merge sometime soon, it is waiting for @ichard26's review, which...
- dont skip formatting #%% #2919 [MarcoGorelli]
  Description Checklist - did you ... Add a CHANGELOG entry if necessary? Add / update tests if necessary? Add...
  - MarcoGorelli: This needs to go in the preview style. Thanks @JelleZijlstra , I've given this a go Wasn't sure...
- Mark Felix and Batuhan as maintainers #2794 [ichard26] T: documentation skip news
  Description Y'all deserve it :) @felix-hilden and @isidentical please check that I chose the right email! Checklist...
- INTERNAL ERROR: Black produced different code on the second pass of the formatter. #2923 [RandyMcMillan] T: bug C: unstable formatting R: outdated
  https://github.com/RandyMcMillan/x20bf/runs/5547164070?check_suite_focus=true error: cannot format...
  - JelleZijlstra: Could you extract the file and give a self-contained repro case?
  - ichard26: Here's the code of the failing file: """Performance tests for object store""" import sys from...
  - ichard26: @RandyMcMillan if you can follow up with a self-contained repro that does fail with the latest...
- Primer: Fix RuntimeError with a closed Event Loop with subprocesses #2193 [cooperlees] T: bug C: maintenance
  From time to time it seems pandas causes an EventLoop RuntimeError error. Let's debug and see if there is something...
- Primer deprecation plan #2821 [JelleZijlstra] C: maintenance
  I removed black-primer from CI in #2809 because it was causing annoying and useless CI failures, but kept the code...
- Farewell black-primer, it was nice knowing you #2924 [ichard26] C: maintenance
  Description Enjoy your retirement at https://github.com/cooperlees/black-primer Resolves #2821 and closes...
  - JelleZijlstra
  - cooperlees: Good bye old warrior. You helped bring back black development to life!
- Remove power hugging formatting from preview #2928 [Shivansh-007] skip news
  - Shivansh-007: Could any of the maintainers add skip news
  - ichard26: Hmmm? what's up with mypy?
    - JelleZijlstra: It thinks this code is unreachable because there's only one enum member.
    - Shivansh-007: Yeah ^
  - ichard26
- Add support for user git ignore configuration file. #2929 [hardkrash] T: enhancement C: command line / config C: file collection
  Is your feature request related to a problem? Please describe. Include all sources of gitignore patterns. I have...
- Format hex code in unicode escape sequences in string literals #2916 [Shivansh-007]
  Closes #2067 Closes #2828 Checklist - did you ... Add a CHANGELOG entry if necessary? Add / update tests if...
  - JelleZijlstra: Suggested change ...
  - JelleZijlstra: Sorry, I actually meant re.VERBOSE (https://docs.python.org/3/library/re.html#re.VERBOSE), which...
    - Shivansh-007: You actually got me there once originally. Done 👍🏻
- legecy install failure #2927 [Drr1122] T: documentation
  I got stuck with this error can someone please help me out
  - JelleZijlstra: Looks like you're trying to install dlib, not Black. You may have better luck on their tracker.
  - Drr1122: Thank you for your quick response sir may i know the possible solution for this problem … On...
- Put blank lines between nested classes in typing stubs #2783 [MarkKoz] T: design F: empty lines S: accepted
  Describe the style change Nested classes in typing stubs should have blank lines between them. Examples in the...
  - jpy-git: Had a quick look at this and, since there's no special consideration given to whether an...
- Addition of `isort` to our dev toolchain #2930 [Shivansh-007] C: maintenance
  Currently, the imports exist in any random order as added by the developers (see below), which sometimes makes it...
  - JelleZijlstra: Could also consider using https://github.com/facebookexperimental/usort
- mount #2934 [SUDDSDUDDS] R: invalid T: documentation
  Is this related to a problem? Please describe. Describe the solution you'd like Describe alternatives you've...
  - ichard26: Please avoid opening issues on major OSS projects without context or any information. Thank you!
- G #2933 [Ieatemptiness] R: invalid
- Update pylint config docs #2931 [jpy-git]
  Description Closes #2914. I've confirmed that C0330 & C0326 checks no longer exist in pylint, therefore we can...
  - Shivansh-007
    - Shivansh-007: This comment shouldn't be removed, in case you saw me removing it from my PR and then did the...
    - Shivansh-007: Might be worth adding a small line/note that this configuration is only applicable latest...
  - JelleZijlstra: When were these codes removed? We may still want to mention them in case people use an older...
  - Shivansh-007: CO330 is removed by PyCQA/pylint#3571, I am not sure about the other error code but AFAIK its...
  - jpy-git: @Shivansh-007 C0326 was removed in https://github.com/PyCQA/pylint/pull/3577/files (same release...
  - Shivansh-007
  - JelleZijlstra: Suggested change ...
  - JelleZijlstra
- Add improved docstring processing #2885 [TomFryers]
  Description One of the things discussed in issue #144 was quote placement. Reading through the discussion, there...
- pylint checks seem to no longer exist? #2914 [alkatar21] good first issue T: documentation
  Using black with other tools says for pylint, that one should switch off disable = C0330, C0326, however I find the...
  - graingert: sources for the removals are on the PR #2931 : CO330 is removed by PyCQA/pylint#3571, I am not...
- Writing failed: [Errno 2] No such file or directory: '/home/user/.cache/black/21.11b1/tmpb3yqz52h' #2681 [avatar-lavventura] T: enhancement
  When I update black, or have a clean install I keep seeing following message: load_grammar()] Generating grammar...
  - michaelaye: black should be allowed to do what it needs to do inside its own .cache/black folder, right?
  - avatar-lavventura: @michaelaye Hm I believe black should be allowed to create files inside .cache/black folder. I...
  - michaelaye: Well #2702 was closed with the comment that the issue would not be picked up for a while, so...
  - avatar-lavventura: Ah you are right, I misread it, seems like PR is not resolved :-( During the installation of...
- Does flake8 still ignore W503 by default? #2925 [ichard26] good first issue T: documentation
  Suspect regression. Using v 4.0.1 (Gentoo X86_64). Having just installed black (v22.1.0), reformatting produced...
  - ichard26: I can't reproduce this behaviour but I'm no flake8 pro. If it turns out flake8 requires ignoring...
  - JelleZijlstra: I feel like it's better to err on the side of listing more codes in our docs, just in case...
  - jpy-git: it's still in the default ignores for the latest flake8 (flake8 --help) my guess is they might...
- fmt: skip removes characters from a comment-only line before it #2339 [felix-hilden] T: bug C: invalid code F: comments F: fmtskip
  Describe the bug Comments behave oddly before # fmt: skip lines. I'll try to see if this has been reported later. To...
  - felix-hilden: In #2539 @myw provided additional information on the case where the skipped line is a decorator...
- Black deletes nonempty block comments before decorators left unfromatted with # fmt: skip #2539 [myw] T: bug R: duplicate F: fmtskip
  Bug description: Black deletes nonempty block comments before decorators left unfromatted with #fmt: skip. As a...
  - propertone: Any plans to fix this? This is a pretty high severity bug since it literally deletes your code comments.
  - felix-hilden: This seems like a duplicate (or rather a subset) of #2339. I'll add your debugging there too, so...
- Remove unnecessary parentheses from `with` statements #2926 [jpy-git]
  Description Closes #2921. Aims to remove redundant parentheses from with statements: I currently have one failing...
  - JelleZijlstra: Thanks for your contribution! A few quick things: Under our stability policy...
  - jpy-git: thanks, I've got the tests working now and will refactor slightly to account for the preview mode
  - jpy-git: @JelleZijlstra I've updated the code to only remove the brackets in preview mode now 😄
- "fmt: skip" on colon-terminated lines either fails or moves the directive #2646 [dansebcar] T: bug C: unstable formatting F: fmtskip
  Describe the bug Adding # fmt: skip after a colon (e.g. on the same line as def, if, with or class) either produces...
- "# fmt: skip" does not work defined function #2936 [rpvdkley] T: bug R: duplicate C: unstable formatting F: fmtskip
  Describe the bug Black raises INTERNAL ERROR when # fmt: skip has been added at the end of a def function...
  - felix-hilden: Confirmed on the playground, thanks for reporting!
  - felix-hilden: Also turns out that this is a duplicate of #2646 ty @Shivansh-007
- Remove redundant brackets from `except` clause #2937 [jpy-git] T: enhancement F: parentheses
  Is your feature request related to a problem? Please describe. The except clause can accept a parenthesised tuple of...
  - JelleZijlstra: Agree, this goes with a lot of other cases where we should remove redundant parens. Not sure...