Activity

• psf/black repo issues and pull requests

  • WIP: Added function for vertically aligning inline comments #1904 [rsnk96]

    Enforces vertical alignment of inline comments in consecutive lines Also addresses #379 and partially...

    • dseynhae: It looks like I'm a day late and a dollar short here. I would love to see Black used by my...

  • chore: Set permissions for GitHub actions #3043 [naveensrinivasan] skip news

    Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in...

    • JelleZijlstra: Hmm, it probably shouldn't be saying differences were found, I'll need to look into this 🤔 Yes,...

    • ichard26: Thanks for the contribution @naveensrinivasan ! Congrats on your PR 🎉 And yes we've locked down...

  • flake8 #noqa comments get moved a place where they're ignored #195 [shish] T: design F: comments

    Operating system: Linux Python version: 3.6 Black version: 18.4a5 Does also happen on master: ? Using a long list of...

    • jonasrauber: Shouldn't this work for these two cases? def foo(parameter1: str, parameter2: str) -> None: #...

  • chore: Enable codeql action #3045 [naveensrinivasan]

    This action runs GitHub's industry-leading semantic code analysis engine, CodeQL, against a repository's source code...

    • github-actions: diff-shades results comparing this PR (28bc78a) to main (c940f75). The full diff is available in...

  • follow python typing export requirements #3032 [danpf]

    Description Black's __init__.py file does not explicitly alias imported modules as themselves which is required for...

    • danpf: So does the same aliasing distinction indeed apply to ordinary sources as well? I can't answer...

  • Black stops looking for config at first pyproject.toml file even if there's no black section in it #2863 [slafs] T: enhancement C: configuration

    Disclaimer: I was hesitant whether I should report this as a bug or rather a "Feature request". Describe the bug In...

    • Shivansh-007: I have been super busy for the past month or two due to school, so I haven't been able to...

  • Black's public API #779 [paugier] T: enhancement C: api

    With previous versions, it was possible to just use black.format_str(string) or black.format_str(string,...

    • felix-hilden: We could try to take this forward. Perhaps we can first commit to the simplest API and then...

    • akaihola: Thanks @felix-hilden! Currently, the best candidate we have is probably: def...

  • Add improved docstring processing #2885 [TomFryers]

    Description One of the things discussed in issue #144 was quote placement. Reading through the discussion, there...

    • github-actions: diff-shades results comparing this PR (2360449) to main (c940f75). The full diff is available in...

  • Standardise newlines after module-level docstrings #2996 [jpy-git]

    Description Closes #1872. Does 2 things: a) Refactor EmptyLineTracker for more consistent look-back logic....

    • github-actions: diff-shades results comparing this PR (c8275d0) to main (c940f75). The full diff is available in...

  • Docstring too long (issue #1632 fix) #3044 [idorrington92]

    Description Fixing this issue #1632 where some docstrings were reformatted to be too long Checklist - did you...

    • felix-hilden: Thanks for submitting! Some tests to validate this behaviour would be in order, and we should...

    • JelleZijlstra: Yes, this should be in the preview style.

    • JelleZijlstra: Move this to the "Preview style" section

    • felix-hilden: In addition to having the flag, we have to use it to enable the change. This would currently...

    • idorrington92: In addition to having the flag, we have to use it to enable the change. This would currently...

    • felix-hilden

      • felix-hilden: This should be the other way around, no? The idea is that if preview is enabled, we do the new thing.

        • idorrington92: I've fixed this now. Changed a test to have the old incorrect formatting as well

        • felix-hilden: Please add the tests to a dedicated file and name that file here so we can test with preview on!

        • idorrington92: Do you want the tests in the new file and the old file?

        • idorrington92: I assume you want the old tests as well so I've kept them in

        • felix-hilden: Yeah that works, can't have too many 👍

      • felix-hilden: This should most likely also have the preview check, or I've missed some context.

        • idorrington92: It doesn't make any difference to the output, as if it is a multiline string then it's...

        • felix-hilden: Right, that was the missing context then 😄 It's a-ok! Having all refactors in preview would be.....

    • felix-hilden: Still some comments, hang in there! And thanks for your patience 😄

      • felix-hilden: Suggested change ...

      • felix-hilden: I've tried to think this through, but I'm not 100 % still. Wouldn't this be incorrect if we had...

        • idorrington92: You were right. There were two issues with my original code, the last_line_length actually...

        • felix-hilden: Nice 👍 looking at the new code: are you sure that the prefix doesn't affect the calculation...

        • idorrington92: I was pretty tired when working on this last night, that's my excuse for missing the prefix :p I...

        • felix-hilden: No worries! Thanks for being so quick with the edits 👍

    • github-actions: diff-shades results comparing this PR (85d5bf9) to main (c940f75). The full diff is available in...

    • felix-hilden: The comments are a nice touch 👌 I think I've convinced myself that this is working now, so LGTM! 😄

  • Add script to ease migration to black #3038 [hbrunn]

    Description I was looking for a script to update existing feature branches automatically when introducing black in...

    • StefanRijnhart: As a member of @hbrunn's team, I just tested this script on some of our open PR branches and it...

  • Failed for python3.10 #3047 [mikesongming] T: bug

    Describe the bug Failed to call black in python3.10 environment on MacOSX, which fixed after upgrading typed_ast by...

    • felix-hilden: Thanks for reporting. I think the problem is solved however, since the version you are using is...

  • Move imports of `ThreadPoolExecutor` into `reformat_many()`, allowing Black-in-the-browser #3046 [Zac-HD] skip news

    This is a slight perf win for use-cases that don't invoke reformat_many(), but more importantly to me today it means...

    • JelleZijlstra: I like it! Let's make sure it doesn't break mypyc or anything though.

    • github-actions: diff-shades results comparing this PR (7655683) to main (c940f75). The full diff is available in...

  • Read simple data cases automatically #3034 [saroad2]

    Description When testing black formatting, the simple use cases where defined hard-coded in a list named...

    • felix-hilden: Hi! Thanks for the PR. I like the idea, since it's easier to just put a file in a folder rather...

      • felix-hilden: Suggested change ...

    • saroad2: Hey @felix-hilden and @JelleZijlstra , thank you for the review! Once this PR is approved, I...

    • felix-hilden: Yep, this looks fine! Unless there's some testing-related context I'm unaware of. And thanks for...

    • saroad2: @felix-hilden, would you like me to make the change for all cases in this PR, or in a separate...

    • felix-hilden: A separate PR works just fine! But we like to have at least another maintainer have a look at...

    • JelleZijlstra

    • ichard26: Would this kind of API for read_data be more developer-friendly? source, expected =...

      • ichard26: Do we need this? it's not user facing ...

    • felix-hilden: Certainly works too! If I had to come up with one, and given that soon we won't have any files...

created at 2022-05-06 11:27 by dinghy 0.11.3.